feat(compiler)!: Deduplicate imports #2233
Open
+58
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the binaryen pass to de-duplicate imports, if were against using the binaryen pass I think we can also do this manually in
compcore
and just filter through the imports incompile_imports
but we'll have to manually handle re-patching the import identifiers through the program.This makes developing for runtimes such as
wasmtime
a little nicer.This also adds the
assertWasmSnapshot
which let's us testwat
snapshots for optimizations that occur after, as the regular mashtree snapshots won't catch these, we can get away with a simpleprint("test")
here because multiple places in the runtime importfd_write
.Closes: #2152