This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
[LibOS] Fix a crash after reusing dentry touched by mknod
#2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimakuv
previously approved these changes
Jul 5, 2021
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)
mkow
previously approved these changes
Jul 5, 2021
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
This fixes a crash where we create a named pipe, remove it, and then try to create a normal file with the same name. Unfortunately, fixing the underlying problem (dentry reuse) is more problematic, so this is only a workaround for that specific case. Signed-off-by: Paweł Marczewski <[email protected]>
pwmarcz
force-pushed
the
pawel/fix-mknod-1
branch
from
835d209 to
4e00671
Compare
mkow
approved these changes
Jul 5, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL)
dimakuv
approved these changes
Jul 5, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while investigating #2419. I tried to make a proper fix in PR #2499, but that seems to be blocked by conflict with tmpfs/strfs code. Merging #2499 would probably make an existing memory leak worse, so I would like to take care of tmpfs and strfs first. In the mean time, here is the workaround for the actual crash.
I ticketed the proper fix as #2507 and intend to work on it.
Description of the changes
This fixes a crash where we create a named pipe, remove it, and then try to create a normal file with the same name. Unfortunately, fixing the underlying problem (dentry reuse) is more problematic, so this is only a workaround for that specific case.
How to test this PR?
mkfifothat crashes in same manner on master.This change is