Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
classification_B_company_1 is :
So :
create a product with the following settings should create a new classification.(one tax less)
-> sale_tax_ids : ['account_tax_sale_5_company_1')]
-> purchase_tax_ids : []
create a product with the following settings should create a new classification. (one tax more)
sale_tax_ids : ['account_tax_sale_5_company_1', 'account_tax_sale_20_company_1')]
-> purchase_tax_ids : ['account_tax_purchase_20_company_1']
ref : https://github.com/OCA/account-fiscal-rule/blob/16.0/account_product_fiscal_classification/demo/account_product_fiscal_classification.xml#L31
For the time being, the tests are failing, so the algorithm is not good.
What do you think, @bealdav