Use python ints throughout, adding float64 to test #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Fixes #25, newly ailing test for float64 depending on later PR)
awf
commented
Jun 6, 2024
Comment on lines
+80
to
+83
| # In range - compute value | ||
| if fval is None: | ||
| fval = sign * fsignificand * 2.0**expval | ||
|
|
There was a problem hiding this comment.
Needed to move this below as float64 was overflowing
|
Diff looks fine to me. I haven't confirmed the problem or the fix for 32-bit Python (it's annoying difficult to test) but as the issue reporter has done so it LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add float64 to formats, and update integer computations to handle them.
Fixes #25