Add a note

graphile · Jan 14, 2025 · 13f2bad · 13f2bad
1 parent 35ef6b5
commit 13f2bad
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/grafast/dataplan-pg/src/steps/pgSelect.ts b/grafast/dataplan-pg/src/steps/pgSelect.ts
@@ -3016,6 +3016,9 @@ function calculateLimitAndOffsetSQL(params: {
         : null;
     offsetValue = offset;
   }
+  // PERF: consider changing from `${sql.literal(v)}` to
+  // `${sql.value(v)}::"int4"`. (The advantage being that fewer SQL queries are
+  // generated, and thus chances of reusing a query are greater.)
   const limitSql =
     limitValue == null ? sql.blank : sql`\nlimit ${sql.literal(limitValue)}`;
   const offsetSql =