RFD 0001: Tooling Requirements #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fheinecke
commented
Aug 29, 2023
rosstimothy
reviewed
Aug 29, 2023
rfd/0001-tooling-requirements.md
Outdated
Comment on lines
141
to
143
| Historically this repo has used Dependabot to manage dependency updates. Unfortunately however, Dependabot does not support two key "languages" used by Github Actions: actions themselves (used when building composite actions), and Dockerfiles (used when building Dockerfile actions). As a result, [Renovate](https://docs.renovatebot.com/) will be used for new and migrated projects instead. Renovate is highly flexible and can be configured on a per-project basis. | ||
|
|
||
| Renovate will self-hosted and configured to run every 12 hours. Updates for each project should be grouped as much as reasonably possible to reduce the number of PRs opened at any given time. Update PRs will be assigned to code owners for each project. Digest pinning will be used wherever supported. |
There was a problem hiding this comment.
FWIW we had nothing but problems using renovate to manage dependencies in gravitational/teleport. I would use dependabot, especially now that is has support for grouping PRs, where possible.
There was a problem hiding this comment.
Oh really? I've had the opposite problem (dependabot not working as needed where renovate does) on the cloud-terraform repo (which now uses self-hosted Renovate) , and just a few minutes ago on the cloud repo.
What issues have there been with Renovate on gravitational/teleport?
There was a problem hiding this comment.
- It was updating the indirect dependencies even though we didn't opt in to the behavior and it's supposed to be disabled by default
- It pushed updates for major versions even though we explicitly set the
disableMajorUpdatespreset - It didn't always remove the old version as reported and ignored in Go module update didn't remove the old version renovatebot/renovate#19660
- It sometimes seemed to make up versions that didn't exist
wadells
reviewed
Aug 30, 2023
Co-authored-by: Walt <[email protected]>
zmb3
reviewed
Aug 30, 2023
tcsc
reviewed
Oct 17, 2023
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
 Failed |
Vulnerabilities | 1 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered: https://github.com/gravitational/shared-workflows/blob/fred/rfd-0001/rfd/0001-tooling-requirements.md