Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slack-on-error shared action #197
Add slack-on-error shared action #197
Changes from all commits
1946f6a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For teleport builds (specifically) I feel like we need a bit more info.
E.g. the calling
teleport
ref is probably more important than theteleport.e
ref -- though we should probably ship both.The workflow as is makes sense for stuff like teleport-plugins or other single repo projects.
Architecturally, perhaps we have a teleport specific slack notifier, instead of (what looks like) an agnostic/general purpose action. If we have a teleport specific action, we could probably drop the
repo:
section too, as those become implicit.Spitballing:
✘ Failed:
push-build
/build-mac
/arm64
author: camscaleteleport branch: camh/test/slack-notify commit: 4a8448bf6f
teleport.e branch: XXXXX commit: XXXXX
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please structure this per https://github.com/gravitational/shared-workflows/blob/main/rfd/0001-tooling-requirements.md#repo-structure?