Add navigation to individual aws resource rule tables #49855
+939
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michellescripts
force-pushed
the
michelle/dashboard-nav
branch
from
20d8d78 to
3e5c84f
Compare
michellescripts
force-pushed
the
michelle/dash-tables
branch
from
faad762 to
dd7e49f
Compare
michellescripts
changed the title
michellescripts
force-pushed
the
michelle/dash-tables
branch
from
ee4fd76 to
cf18b6f
Compare
michellescripts
force-pushed
the
michelle/dashboard-nav
branch
from
3e5c84f to
d41e609
Compare
michellescripts
force-pushed
the
michelle/dash-tables
branch
from
cf18b6f to
c12ec67
Compare
michellescripts
force-pushed
the
michelle/dashboard-nav
branch
4 times, most recently
from
144f708 to
db1285e
Compare
michellescripts
force-pushed
the
michelle/dash-tables
branch
6 times, most recently
from
32c924a to
5b0dae1
Compare
michellescripts
force-pushed
the
michelle/dash-tables
branch
5 times, most recently
from
c8bb537 to
49ab3fc
Compare
michellescripts
force-pushed
the
michelle/dash-tables
branch
from
49ab3fc to
ace89fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds rules tables for each AWS resource, and an empty placeholder table for RDS agents.
Does not include:
Refactor Notes:
web/packages/design/src/Tabs/Tabs.tsis pulled frome/web/teleport/src/AccessMonitoring/AccessMonitoring.tsx. Once merged & backported, we can update the Access Monitoring component to use/design.I also re-wrote
web/packages/teleport/src/generateResourcePath.test.tsto accept a generic path that contains all parameters rather than using a predetermined path with a subset of params.With mocked data:
Screen.Recording.2024-12-18.at.1.05.32.PM.mov
Supports #49088
Hold on: