Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workload Identity: Add minimally viable implementation of IssueWorkloadIdentity RPC #49943

Merged

Conversation

strideynet
Copy link
Contributor

@strideynet strideynet commented Dec 9, 2024

Part of #49574

As per RFD 191

Depends on #50163

This PR adds a minimally viable implemented of the IssueWorkloadIdentity RPC, which issues an X509 or JWT SVID based on a WorkloadIdentity resource configuration. This PR should act as enough of a foundation that more atomic PRs can be raised to add functionality, and, work can begin on the client-side implementation.

As this RPC isn't quite complete, for now, it'll be gated behind a "TELEPORT_WORKLOAD_IDENTITY_UX_EXPERIMENT" environment variable.

@strideynet strideynet force-pushed the strideynet/basic-workload-identity-issuance-service branch 4 times, most recently from 87cafbe to 72bdfe8 Compare December 13, 2024 14:40
@strideynet strideynet changed the base branch from master to strideynet/protos-workload-id-issuance-and-attrs December 13, 2024 14:40
@strideynet strideynet changed the title Strideynet/basic workload identity issuance service Workload Identity: Add minimally viable implementation of IssueWorkloadIdentity RPC Dec 13, 2024
@strideynet strideynet marked this pull request as ready for review December 13, 2024 15:35
@strideynet strideynet added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v16 backport/branch/v17 labels Dec 13, 2024
@strideynet strideynet force-pushed the strideynet/protos-workload-id-issuance-and-attrs branch from f9f9f11 to 1206c3b Compare December 17, 2024 10:18
Base automatically changed from strideynet/protos-workload-id-issuance-and-attrs to master December 17, 2024 11:59
@strideynet strideynet force-pushed the strideynet/basic-workload-identity-issuance-service branch from 2791f59 to 5225a81 Compare December 17, 2024 14:00
Copy link
Contributor

@timothyb89 timothyb89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nits!

@strideynet strideynet added this pull request to the merge queue Dec 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2024
@strideynet strideynet added this pull request to the merge queue Dec 18, 2024
Merged via the queue into master with commit 3d6d587 Dec 18, 2024
41 checks passed
@strideynet strideynet deleted the strideynet/basic-workload-identity-issuance-service branch December 18, 2024 11:50
@public-teleport-github-review-bot

@strideynet See the table below for backport results.

Branch Result
branch/v16 Create PR
branch/v17 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v16 backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/lg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants