-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workload Identity: Add minimally viable implementation of IssueWorkloadIdentity RPC #49943
Merged
strideynet
merged 6 commits into
master
from
strideynet/basic-workload-identity-issuance-service
Dec 18, 2024
Merged
Workload Identity: Add minimally viable implementation of IssueWorkloadIdentity RPC #49943
strideynet
merged 6 commits into
master
from
strideynet/basic-workload-identity-issuance-service
Dec 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strideynet
force-pushed
the
strideynet/basic-workload-identity-issuance-service
branch
4 times, most recently
from
December 13, 2024 14:40
87cafbe
to
72bdfe8
Compare
strideynet
changed the base branch from
master
to
strideynet/protos-workload-id-issuance-and-attrs
December 13, 2024 14:40
strideynet
changed the title
Strideynet/basic workload identity issuance service
Workload Identity: Add minimally viable implementation of IssueWorkloadIdentity RPC
Dec 13, 2024
strideynet
added
no-changelog
Indicates that a PR does not require a changelog entry
backport/branch/v16
backport/branch/v17
labels
Dec 13, 2024
strideynet
force-pushed
the
strideynet/protos-workload-id-issuance-and-attrs
branch
from
December 17, 2024 10:18
f9f9f11
to
1206c3b
Compare
Base automatically changed from
strideynet/protos-workload-id-issuance-and-attrs
to
master
December 17, 2024 11:59
strideynet
force-pushed
the
strideynet/basic-workload-identity-issuance-service
branch
from
December 17, 2024 14:00
2791f59
to
5225a81
Compare
timothyb89
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of nits!
ryanclark
approved these changes
Dec 18, 2024
public-teleport-github-review-bot
bot
removed request for
avatus and
capnspacehook
December 18, 2024 10:58
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 18, 2024
strideynet
deleted the
strideynet/basic-workload-identity-issuance-service
branch
December 18, 2024 11:50
@strideynet See the table below for backport results.
|
This was referenced Dec 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/branch/v16
backport/branch/v17
no-changelog
Indicates that a PR does not require a changelog entry
size/lg
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #49574
As per RFD 191
Depends on #50163
This PR adds a minimally viable implemented of the IssueWorkloadIdentity RPC, which issues an X509 or JWT SVID based on a WorkloadIdentity resource configuration. This PR should act as enough of a foundation that more atomic PRs can be raised to add functionality, and, work can begin on the client-side implementation.
As this RPC isn't quite complete, for now, it'll be gated behind a "TELEPORT_WORKLOAD_IDENTITY_UX_EXPERIMENT" environment variable.