Show kube cluster name at the beginning of kube tabs #50376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravicious
approved these changes
Dec 18, 2024
zmb3
approved these changes
Dec 18, 2024
public-teleport-github-review-bot
bot
removed the request for review
from lcharkiewicz
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few months ago, we added a possibility to change the shell in local tabs. During that work, we also unified
doc.terminal_shellanddoc.gateway_kubetab names, making them show cwd, shell, and then resource name.It turns out that this was not a good change for kube sessions, as we show the most important information at the very end, making it invisible when there are more tabs.
I could only change the order, but after a short discussion with @lcharkiewicz, I decided to completely remove cwd, as it is often truncated, which doesn't make it useful. Moreover, cwd doesn't seem to be essential information for kube sessions, so we can avoid cluttering the tab name.
changelog: Reverted a change that caused the Kubernetes cluster name to be displayed at the end of the tab title in Teleport Connect