126 grapher registration with chronovisor #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ibrodkin
commented
Apr 18, 2024
ibrodkin
commented
- Finished Grapher RPC registration with ChronoVisor
- Introduced RecordingGroup
- Reworked KeeperRegistry organization to have Keepers & Graphers organized by RecordingGroups
- added notion of Active recordingGroups and activeStories-to-recordingGroups mapping in the KeeperRegistry
- added uniform_distribution with Mersene Twister generator to choose recording group for the new story recording
- reworked grapher & keeper notification logic for story recording start/stop
Always use high-speed network IP (172.25.x.x for Ares)
Move getting IP from hostname to a separate function
…DataStoreAdminService set to their own IP
Add work_dir, conf_file and help command line argument Add color formatting
Change from getent to dig to get IP from hostname Rename HOSTNAME_HS_NET_POSTFIX to HOSTNAME_HS_NET_SUFFIX'
EnekoGonzalez3
approved these changes
Apr 18, 2024
fkengun
reviewed
Apr 19, 2024
fkengun
reviewed
Apr 19, 2024
fkengun
reviewed
Apr 19, 2024
fkengun
reviewed
Apr 22, 2024
fkengun
reviewed
Apr 24, 2024
fkengun
reviewed
Apr 24, 2024
| , story_id); | ||
| } | ||
| theKeeperRegistry->notifyRecordingGroupOfStoryRecordingStop(story_id); | ||
|
|
||
| return chronolog::CL_SUCCESS; |
There was a problem hiding this comment.
TODO: we need a chronolog::ReleaseStoryResponseMsg to return error code to clients.
fkengun
reviewed
Apr 24, 2024
fkengun
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.