Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field "requiredForLanguages" #32

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

utarwyn
Copy link
Member

@utarwyn utarwyn commented Jan 31, 2024

Made the same changes as SonarSource/SonarJS#4314 to support new SonarQube 10.4 DownloadOnlyWhenRequired feature.

  • Minimum version of sonar-packaging-maven-plugin is 1.22.0.705
  • Property <requiredForLanguages> added with applicable languages (js,ts,web,yaml)
  • Manifest is generated as expected

I have not tested with SonarQube 10.4 yet, because the software has to be compiled manually and I haven't done that on my machine. But I believe that this parameter will be correctly interpreted by SonarQube.

Closes #31

@utarwyn utarwyn added the 🚀 enhancement New feature or request label Jan 31, 2024
@utarwyn utarwyn requested a review from dedece35 January 31, 2024 18:42
@utarwyn utarwyn self-assigned this Jan 31, 2024
dedece35
dedece35 previously approved these changes Jan 31, 2024
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@utarwyn utarwyn merged commit bde1f95 into main Feb 1, 2024
5 checks passed
@utarwyn utarwyn deleted the 31-download-only-when-required branch February 1, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make "ecoCode-javascript" compatible with SonarQube 10.4 "DownloadOnlyWhenRequired" feature
2 participants