Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use symbol in obsolete variable sexp #24

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Use symbol in obsolete variable sexp #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion memento-mori.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
:type 'string
:group 'memento-mori)
(make-obsolete-variable 'memento-mori-birth-date
"memento-mori-mementos" "0.2.1")
'memento-mori-mementos "0.2.1")

(defcustom memento-mori-mementos
'(("%y years since Harrison Bergeron was published"
Expand Down Expand Up @@ -240,9 +240,9 @@
:type '(repeat string))

(defvar memento-mori-string ""
"The string shown in the mode line when `memento-mori-mode' is enabled.

Check warning on line 243 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.3, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.

Check warning on line 243 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (24.4, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.

Check warning on line 243 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.1, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.

Check warning on line 243 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (25.1, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.

Check warning on line 243 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (27.2, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.

Check warning on line 243 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (27.1, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.

Check warning on line 243 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.2, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.
This is not meant to be changed by the user, but can be used in places
such as org-mode agendas to display the current momento.")

Check warning on line 245 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.3, false) 

Lisp symbol ‘org-mode’ should appear in quotes

Check warning on line 245 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (24.4, false) 

Lisp symbol `org-mode' should appear in quotes

Check warning on line 245 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.1, false) 

Lisp symbol ‘org-mode’ should appear in quotes

Check warning on line 245 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (25.1, false) 

Lisp symbol ‘org-mode’ should appear in quotes

Check warning on line 245 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (27.2, false) 

Lisp symbol ‘org-mode’ should appear in quotes

Check warning on line 245 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (28.1, false) 

Lisp symbol ‘org-mode’ should appear in quotes

Check warning on line 245 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (27.1, false) 

Lisp symbol ‘org-mode’ should appear in quotes

Check warning on line 245 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (snapshot, false) 

Lisp symbol ‘org-mode’ should appear in quotes

Check warning on line 245 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (29.1, false) 

Lisp symbol ‘org-mode’ should appear in quotes

Check warning on line 245 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (28.2, false) 

Lisp symbol ‘org-mode’ should appear in quotes

Check warning on line 245 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.2, false) 

Lisp symbol ‘org-mode’ should appear in quotes

Check warning on line 245 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (release-snapshot, false) 

Lisp symbol ‘org-mode’ should appear in quotes

(defvar memento-mori--modeline-construct
`(memento-mori-mode
Expand Down Expand Up @@ -274,7 +274,7 @@
(error "Birth date not set. Try M-x customize-group memento-mori")))

(defun memento-mori--parse-time (value)
"Return your birth time in `encode-time' format.

Check warning on line 277 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.3, false) 

Argument ‘value’ should appear (as VALUE) in the doc string

Check warning on line 277 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (24.4, false) 

Argument `value' should appear (as VALUE) in the doc string

Check warning on line 277 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.1, false) 

Argument ‘value’ should appear (as VALUE) in the doc string

Check warning on line 277 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (25.1, false) 

Argument ‘value’ should appear (as VALUE) in the doc string

Check warning on line 277 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (27.2, false) 

Argument ‘value’ should appear (as VALUE) in the doc string

Check warning on line 277 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (28.1, false) 

Argument ‘value’ should appear (as VALUE) in the doc string

Check warning on line 277 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (27.1, false) 

Argument ‘value’ should appear (as VALUE) in the doc string

Check warning on line 277 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (snapshot, false) 

Argument ‘value’ should appear (as VALUE) in the doc string

Check warning on line 277 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (29.1, false) 

Argument ‘value’ should appear (as VALUE) in the doc string

Check warning on line 277 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (28.2, false) 

Argument ‘value’ should appear (as VALUE) in the doc string

Check warning on line 277 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.2, false) 

Argument ‘value’ should appear (as VALUE) in the doc string

Check warning on line 277 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (release-snapshot, false) 

Argument ‘value’ should appear (as VALUE) in the doc string
The birth time is parsed from `memento-mori-birth-date' using
`parse-time-string'. An error is signaled if it is not valid."
(when (symbolp value)
Expand Down Expand Up @@ -308,7 +308,7 @@
"Randomly choose a quote from `memento-mori-quotes'."
(nth (random (length memento-mori-quotes)) memento-mori-quotes))

(defun memento-mori--format-memento (memento)

Check warning on line 311 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.3, false) 

Unused lexical variable ‘current-time-list’

Check warning on line 311 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (24.4, false) 

Unused lexical variable `current-time-list'

Check warning on line 311 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.1, false) 

Unused lexical variable ‘current-time-list’

Check warning on line 311 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (25.1, false) 

Unused lexical variable ‘current-time-list’

Check warning on line 311 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (27.2, false) 

Unused lexical variable ‘current-time-list’

Check warning on line 311 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (27.1, false) 

Unused lexical variable ‘current-time-list’

Check warning on line 311 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.2, false) 

Unused lexical variable ‘current-time-list’
"Format MEMENTO based on the current time."
(let* ((format-string (car memento))
(args-plist (cdr memento))
Expand All @@ -316,7 +316,7 @@
(since-value (plist-get args-plist :since))
(_ (when (not (or until-value since-value))
(error ":since or :until required. Parsing %s" memento)))
(current-time-list nil)

Check warning on line 319 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (28.1, false) 

Unused lexical variable `current-time-list'

Check warning on line 319 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (28.2, false) 

Unused lexical variable `current-time-list'
(until-seconds (when until-value
(float-time
(time-subtract
Expand Down Expand Up @@ -347,7 +347,7 @@
(/ since-seconds (* 60 60 24))
days))
(t 0)))))
(format-spec format-string

Check warning on line 350 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.3, false) 

format-spec called with 3 arguments, but accepts only 2

Check warning on line 350 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (24.4, false) 

format-spec called with 3 arguments, but accepts only 2

Check warning on line 350 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.1, false) 

format-spec called with 3 arguments, but accepts only 2

Check warning on line 350 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (25.1, false) 

format-spec called with 3 arguments, but accepts only 2

Check warning on line 350 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.2, false) 

format-spec called with 3 arguments, but accepts only 2
`((?Y . ,years)
(?y . ,(truncate years))
(?M . ,months)
Expand Down Expand Up @@ -383,13 +383,13 @@
(when (and memento-mori-initial-scratch-message
(boundp 'initial-scratch-message))
(setq initial-scratch-message
(format-spec memento-mori-initial-scratch-message

Check warning on line 386 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.3, false) 

format-spec called with 3 arguments, but accepts only 2

Check warning on line 386 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (24.4, false) 

format-spec called with 3 arguments, but accepts only 2

Check warning on line 386 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.1, false) 

format-spec called with 3 arguments, but accepts only 2

Check warning on line 386 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (25.1, false) 

format-spec called with 3 arguments, but accepts only 2

Check warning on line 386 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.2, false) 

format-spec called with 3 arguments, but accepts only 2
`((?m . ,memento-mori-string)
(?q . ,(memento-mori--random-quote)))
'ignore))))

(defun memento-mori--add-mementos ()
"Adds constructs to modeline and frame-title to display mementos.

Check warning on line 392 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.3, false) 

Probably "Adds" should be imperative "Add"

Check warning on line 392 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (24.4, false) 

Probably "Adds" should be imperative "Add"

Check warning on line 392 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.1, false) 

Probably "Adds" should be imperative "Add"

Check warning on line 392 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (25.1, false) 

Probably "Adds" should be imperative "Add"

Check warning on line 392 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (27.2, false) 

Probably "Adds" should be imperative "Add"

Check warning on line 392 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (28.1, false) 

Probably "Adds" should be imperative "Add"

Check warning on line 392 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (27.1, false) 

Probably "Adds" should be imperative "Add"

Check warning on line 392 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (snapshot, false) 

Probably "Adds" should be imperative "Add"

Check warning on line 392 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (29.1, false) 

Probably "Adds" should be imperative "Add"

Check warning on line 392 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (28.2, false) 

Probably "Adds" should be imperative "Add"

Check warning on line 392 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.2, false) 

Probably "Adds" should be imperative "Add"

Check warning on line 392 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (release-snapshot, false) 

Probably "Adds" should be imperative "Add"
Where it adds it is controlled by `memento-mori-display-in-modeline' and
`memento-mori-display-in-frame-title'.

Expand Down
Loading