Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-6698][FOLLOWUP] Fix build of DeepLearningSHAPTest on Java 13+ #15818

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

mn-mikke
Copy link
Collaborator

GH-6698

Java versions 13+ have problems to compile large try statement section:


[2023-10-12T15:49:56.532Z] > Task :h2o-algos:compileTestJava

[2023-10-12T15:49:56.532Z] /home/jenkins/slave_dir_from_mr-0xc1/workspace/2o-3-nightly-pipeline_rel-3.44.0/java-13-smoke/h2o-3/h2o-algos/src/test/java/hex/deeplearning/DeepLearningSHAPTest.java:1677: error: code too large for try statement

[2023-10-12T15:49:56.532Z]     try {

[2023-10-12T15:49:56.532Z]         ^

[2023-10-12T15:49:56.532Z] /home/jenkins/slave_dir_from_mr-0xc1/workspace/2o-3-nightly-pipeline_rel-3.44.0/java-13-smoke/h2o-3/h2o-algos/src/test/java/hex/deeplearning/DeepLearningSHAPTest.java:1668: error: code too large

[2023-10-12T15:49:56.532Z]   public void testClassificationTanhDeepSHAPComparison() {

[2023-10-12T15:49:56.532Z]               ^

I suggest to separate asserts to a dedicated method. This approach works fixed the problem locally.

@mn-mikke mn-mikke merged commit 096f69d into rel-3.44.0 Oct 12, 2023
@mn-mikke mn-mikke deleted the mn/GH-6698 branch October 12, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants