Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make incorrect hotspot reset task on click #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make incorrect hotspot reset task on click #24

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2368e96
Make incorrect hotspot reset task on click
otacke May 24, 2019
d383ad1
Make eslint happy
otacke May 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions image-hotspot-question.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,8 @@ H5P.ImageHotspotQuestion = (function ($, Question) {
* @param {Object} hotspot Hotspot parameters.
*/
ImageHotspotQuestion.prototype.createHotspotFeedback = function ($clickedElement, mouseEvent, hotspot) {
const self = this;

// Do not create new hotspot if one exists
if (this.hotspotFeedback.hotspotChosen) {
return;
Expand Down Expand Up @@ -252,10 +254,16 @@ H5P.ImageHotspotQuestion = (function ($, Question) {
if (hotspot && hotspot.userSettings.correct) {
this.hotspotFeedback.$element.addClass('correct');
this.finishQuestion();
} else {
}
else {
// Wrong answer, show retry button
if (this.params.behaviour.enableRetry) {
this.showButton('retry-button');
this.hotspotFeedback.$element.click(function (event) {
event.stopPropagation();
self.resetTask();
});

}
}

Expand Down Expand Up @@ -393,7 +401,8 @@ H5P.ImageHotspotQuestion = (function ($, Question) {
if (parentWidth < naturalWidth) {
// Scale image down
neededHeight = parentWidth * imageRatio;
} else {
}
else {
// Scale image to natural size
this.$img.width(naturalWidth);
neededHeight = naturalHeight;
Expand Down