-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation in bytecode mode #55
Conversation
This should solve the issue in ocaml/opam-repository#25033
I merged it. /cc @sim642 |
Do you want to update the release or I can merge that with the conflict with bytecode compiler? |
Thank you! Your patch could be released with next release. I don't know how to update the release. Is it close the PR on opam repository and re-release the same version with your patch? |
It shouldn't be the same release because 1.3.0 is already in our GitHub releases etc. I can release 1.3.1 with this soon too. |
Could you release 1.3.1? I've already forgotten how to use dune-release. |
CHANGES: ### Fixed * Fix bytecode-only installation (hackwaly/ocamlearlybird#55).
This doesn't seem to really help: ocaml/opam-repository#25063 fails with
It's the same problem, just from a slightly different place. |
Mmh, very strange. I'll try to look into it. Unfortunately I cannot do it for some time still. |
I suspect the reason is this line: Line 4 in 63f0a3f
In dune's linking modes, this demands both native and bytecode binaries, but that might not be necessary. The default |
This should solve the issue in ocaml/opam-repository#25033