-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Run a local PostgreSQL instance in Docker #230
Conversation
We need this to get a version of colima that runs on Linux.
94e027a
to
378f17d
Compare
This uses `colima` to create the VMs used by the `docker` executable, so the user need not have Docker installed, though it should co-exist with Docker (via the use of Docker contexts) if they do. The configuration makes use of a persistent Docker volume, so the database should survive a container restart (and even a PostgreSQL version upgrade). This is all pretty imperative, but I don't know of a good way around that which is also portable. Docs are forthcoming in a subsequent commit.
@brprice This works great on macOS. Can you test it on Linux? Mainly I just need to know whether If everything's working, when you get to and execute the
Instructions are in the README. Thanks! |
reason. The container & database those commands create will persist | ||
across reboots, and will remain on your system until you delete them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth mentioning where they live / how to delete them?
README.md
Outdated
This script runs the `primer-postgres` container. The container will | ||
keep running until you reboot your host machine, or you stop the | ||
container yourself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be worth saying how to stop the container
These are useful for debugging Docker issues.
This needs a little more documentation and then it'll be ready to go. |
There were some issues with the previous versions, which I've now addressed. I also added a script to stop the container.
Fixes #229.