[3팀 허원영] [Chapter 1-2] 프레임워크 없이 SPA 만들기 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdlee0619
reviewed
Dec 28, 2024
Comment on lines
+6
to
+18
| if (!container._oldVNode) { | ||
| container._oldVNode = null; | ||
| } | ||
|
|
||
| const normalizedVNode = normalizeVNode(vNode); | ||
| if (!container._oldVNode) { | ||
| container.appendChild(createElement(normalizedVNode)); | ||
| } else { | ||
| updateElement(container, normalizedVNode, container._oldVNode); | ||
| } | ||
|
|
||
| setupEventListeners(container); | ||
| container._oldVNode = normalizedVNode; |
There was a problem hiding this comment.
저는 변수를 따로 만들어둔 다음에 oldVNode를 저장해뒀는데, container에 _oldVNode를 프로터피 바인딩을 사용하는 방식이 더 깔끔해보이는 것 같아요!
| target.setAttribute("class", newProps[key]); | ||
| } else if (key.startsWith("on") && typeof newProps[key] === "function") { | ||
| const eventName = key.toLowerCase().substring(2); | ||
| // removeEvent(target, eventName); |
There was a problem hiding this comment.
저는 주석은 항상 지워두는 편인데, 예전에 다니던 회사에서는 남겨두는 경우도 많이 본 것 같아요..!
원영님은 주석에 대해서 어떻게 생각하시는지 궁금합니다ㅎㅎ
There was a problem hiding this comment.
사실 저런 주석은 지우는게 맞는거 같아요 ㅋㅋ 코치님도 사용하지 않는 주석을 지우라고 피드백 주셨더라구요...
Blue-Kite
approved these changes
Dec 28, 2024
| @@ -53,5 +53,26 @@ export const globalStore = createStore( | |||
| userStorage.reset(); | |||
| return { ...state, currentUser: null, loggedIn: false }; | |||
| }, | |||
| likePost(state, postId) { | |||
There was a problem hiding this comment.
이번주 수고하셨습니다. 좋아요 기능을 여기서 관리하는게 깔끔하군요
Suyeon-B
reviewed
Dec 28, 2024
| export const PostForm = () => { | ||
| const { addPost } = globalStore.actions; |
There was a problem hiding this comment.
createStore에 actions도 따로 정의가 되어 있었군요! 🤩
There was a problem hiding this comment.
이번에 코치님께 이런 피드백을 받았어요~!!
원영님께도 도움이 될 것 같아서 공유드립니다 🙇♀️ 👍
lshyun955
reviewed
Dec 28, 2024
Comment on lines
+3
to
+11
| /** | ||
| * @typedef {Object} VNode | ||
| * @property {string|function} type - 요소의 타입 | ||
| * @property {Object | null} props - 요소의 속성 | ||
| * @property {Array<*>} children - 요소의 자식 노드 | ||
| */ | ||
|
|
||
| function updateAttributes($el, props) {} | ||
| export function createElement(vNode) { | ||
| if ( |
There was a problem hiding this comment.
원영님 코드를 보면 코드 자체도 읽기 편한데 주석도 굉장히 잘 작성되어 있네요...!👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
과제 체크포인트
기본과제
가상돔을 기반으로 렌더링하기
이벤트 위임
심화 과제
1) Diff 알고리즘 구현
2) 포스트 추가/좋아요 기능 구현
과제 셀프회고
기술적 성장
코드 품질
학습 효과 분석
과제 피드백
리뷰 받고 싶은 내용