ApplicationRouterImpl will catch all Exceptions including IllegalArgumentException #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Had the same Problem and would totally appreciate more control over the thrown exception |
|
@jamesagnew could you please have a look at this PR? This is a problem for one of our customers. |
|
hi, it took me a long time to find out that the exception cannot be handled. I would be very happy about a quick solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a problem that a customer sends us some invalid HL7 message that contains a line break inside an ORC segment. When receiving this message by TCP/IP, the constructor of ca.uhn.hl7v2.parser.NonStandardStructureDefinition will throw an IllegalArgumentException that is not handled in ApplicationRouterImpl and the exception is only handled at the Runner level.
This means that the sender of the message will never receive any NACK or something else. Instead it will just receive nothing until the connection times out.
This patch is meant to fix this behaviour.