Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefer npm ci over npm i #101

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Conversation

jameswragg
Copy link

Re #100

@Nargonath Nargonath self-assigned this Dec 11, 2023
Copy link
Member

@Nargonath Nargonath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM. I tested a npm run build:web locally and it failed. Here is the result:

image

Not sure what the root cause. I have dug into it.

@jameswragg
Copy link
Author

jameswragg commented Dec 11, 2023 via email

@Nargonath
Copy link
Member

Yeah that's what I thought as well. The image is still using node 14 so we should probably upgrade it anyway.

@jameswragg
Copy link
Author

@Nargonath do you want me to update the base image in this PR?
If so, the current LTS (20)?

Copy link
Member

@Nargonath Nargonath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's separate the concern. I'll merge this one and if you want to open another one to upgrade the base image version, feel free to do so. Thanks 🙏

@Nargonath Nargonath merged commit 782f36b into hapipal:flavor-docker Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants