Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add controller.extraServices list #86

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hedgieinsocks
Copy link

This PR suggests adding controller.extraServices key of list type for declaring additional controller services.

This will make it possible for us to declare two controller services for MetalLB like this:

controller:
  service:
    annotations:
      metallb.universe.tf/loadBalancerIPs: 1.2.3.10
  extraServices:
    - annotations:
        metallb.universe.tf/loadBalancerIPs: 1.2.3.11

And get the following result:

apiVersion: v1
kind: Service
metadata:
  annotations:
    metallb.universe.tf/loadBalancerIPs: 1.2.3.10
  labels:
    helm.sh/chart: haproxy-ingress-0.15.0-alpha.3
    app.kubernetes.io/name: haproxy-ingress
    app.kubernetes.io/instance: haproxy-ingress
    app.kubernetes.io/version: "v0.15.0-alpha.3"
    app.kubernetes.io/managed-by: Helm
  name: haproxy-ingress
  namespace: default
spec:
  externalTrafficPolicy: "Local"
  ports:
    - name: "http-80"
      port: 80
      protocol: TCP
      targetPort: http
    - name: "https-443"
      port: 443
      protocol: TCP
      targetPort: https
  selector:
    app.kubernetes.io/name: haproxy-ingress
    app.kubernetes.io/instance: haproxy-ingress
  type: "LoadBalancer"
---
kind: Service
metadata:
  annotations:
    metallb.universe.tf/loadBalancerIPs: 1.2.3.11
  labels:
    helm.sh/chart: haproxy-ingress-0.15.0-alpha.3
    app.kubernetes.io/name: haproxy-ingress
    app.kubernetes.io/instance: haproxy-ingress
    app.kubernetes.io/version: "v0.15.0-alpha.3"
    app.kubernetes.io/managed-by: Helm
  name: haproxy-ingress-extra-0
  namespace: default
spec:
  externalTrafficPolicy: "Local"
  ports:
    - name: "http-80"
      port: 80
      protocol: TCP
      targetPort: http
    - name: "https-443"
      port: 443
      protocol: TCP
      targetPort: https
  selector:
    app.kubernetes.io/name: haproxy-ingress
    app.kubernetes.io/instance: haproxy-ingress
  type: "LoadBalancer"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant