Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of v1.0 of Hedera DID Method (HIP-27) #164

Open
wants to merge 168 commits into
base: main
Choose a base branch
from

Conversation

derek-meeco
Copy link

Description:

This update aligns the JavaScript SDK with the Hedera DID Method v1.0.

This updated specification for the Hedera Hashgraph DID Method aligns with the Decentralized Identifiers (DIDs) v1.0 W3C Recommendation, published 19 July 2022.

The specification allows for DID resolution via construction of DID document elements from HCS messages, or from lookup of DID document from IPFS via a CID reference registered via a HCS message.

This is part of HIP-27: DID improvements to offer a broader support and interoperability for the Hedera DID method

linasi and others added 30 commits January 26, 2022 16:12
- FileId is not longer used in HcsDid;
- DidDocumentBase does not append verificationMethods and authentication parts to the document if didRootKey is missing;
- A few TODO comments added;

TODO:
- Fix tests


Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
…fix failing tests

Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Add basic prettier configuration and format the source

Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
added minimum node version

Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
adding demo page to test did and did document creation

Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
added property assertion method to did-doc

Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
added multibase support for public key

Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Linas Išganaitis and others added 17 commits February 27, 2023 17:48
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Don't apply key codec before encoding with multibase

Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
… publicKeyBase58, encoding of the value updated; Fixing tests.

Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Upgrade @hashgraph/sdk to 2.28.0; publicKeyMultibase is replaced with…

Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Merge from upstream main

Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Fixes some test failures


Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Add support for resolving DID documents from IPFS

Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
- Fix method name for json tree
- Add missing return for fetched json


Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Fix some issues resolving IPFS DIDs

Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Add links to did method spec and hedera sdk

Signed-off-by: Derek Munneke (Meeco) <[email protected]>; Signed-off-by: Derek Munneke <[email protected]>; Signed-off-by: Jan Vereecken <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Linas Išganaitis <[email protected]>; Signed-off-by: Vijay Shiyani <[email protected]>; Signed-off-by: Zak Barbuto <[email protected]>; Signed-off-by: elena <[email protected]>; Signed-off-by: linasi <[email protected]>; Signed-off-by: vijay <[email protected]>
Reccetech
Reccetech previously approved these changes May 30, 2024
Copy link

@Reccetech Reccetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge approved.

Signed-off-by: Derek Munneke <[email protected]>
Signed-off-by: Derek Munneke (Meeco) <[email protected]>
Copy link
Collaborator

@gregscullard gregscullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, please review comments.
Note: There may be some benefits to code re-use in the tests, many of the comments refer to the same issue(s).

Thank you

@@ -9,16 +9,16 @@ import {HcsDid} from "./hcs/did/hcs-did";
* @return {@link HederaDid} instance.
*/
export class DidParser {
public static parse(didString: string): HederaDid {
public static parse(didString: string): HcsDid {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be a breaking change from the previous version (method response change), is this acceptable ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 1.0 of the DID Method is a breaking change for 0.9 spec.

The package version is a major version change; or should this be published as a different package in a different repo?

The code had been submitted earlier to a different repository - that could be used for 1.0 DID method, and we could leave this repo for support of the 0.9 DID method?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same package, versioning imo takes care of notifying it's a major/breaking update. Devs have a choice to pull the latest version, or older.

src/identity/hcs/did/hcs-did-message.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants