Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mount point for networks-config.json when running in Docker #761

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Add mount point for networks-config.json when running in Docker #761

merged 1 commit into from
Nov 22, 2023

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Nov 22, 2023 •
edited
Loading

Description:

This allows to provide a custom networks-config.json when running the explorer from a Docker container, for instance to easily:

  • use connection to a LocalNode
  • use a completely custom (set of) network(s) for testing purposes

@svienot svienot changed the title Add mount point for networks-config.json when running in Dcker Add mount point for networks-config.json when running in Docker Nov 22, 2023
@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 87.35% 32852 / 37610
🔵 Statements 87.35% 32852 / 37610
🔵 Functions 66.83% 814 / 1218
🔵 Branches 83.54% 3645 / 4363
File CoverageNo changed files found.
Generated in workflow #563

@svienot svienot requested a review from ericleponner November 22, 2023 10:37
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@svienot svienot self-assigned this Nov 22, 2023
@svienot svienot merged commit 11ba930 into main Nov 22, 2023
6 checks passed
@svienot svienot deleted the add-localnode-config branch November 22, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericleponner ericleponner ericleponner approved these changes

Assignees

@svienot svienot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svienot @ericleponner