00765 Explorer should not report "Decoding Error" when error is empty in a contract result #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de "0x" error message. Signed-off-by: Eric Le Ponner <[email protected]>
…no longer reported as decoding error. Signed-off-by: Eric Le Ponner <[email protected]>
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
|
Kudos, SonarCloud Quality Gate passed!
|
svienot
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes below fix false decoding error reported in
Contract Resultsection.They also add a unit test case for asserting this.
Related issue(s):
Fixes #765
Notes for reviewer:
Use mainnet transaction 1700549131.961381389.
Checklist