Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

00694 display both raw and b64-decoded values of memo when relevant #775

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Nov 28, 2023

Description:

In AccountDetails and ContractDetails views, when we find that the memo is candidate to Base64 decoding, we now show both the raw value and the decoded value. So if the value is, in fact, not encoded, it is still legible.

This happens only in case the value has not been interpreted (as a URL, an IPFS hash...) since that would mean we were indeed not confused about the encoding.

Related issue(s):

Fixes #694

Notes for reviewer:

Visible on staging server.
Examples:

  • actual B64 encoding Screenshot 2023-11-28 at 12 42 37
  • not a B64 encoding Screenshot 2023-11-28 at 12 44 00

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@svienot svienot requested a review from ericleponner November 28, 2023 11:48
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 87.49% 33160 / 37902
🔵 Statements 87.49% 33160 / 37902
🔵 Functions 66.86% 819 / 1225
🔵 Branches 83.64% 3676 / 4395
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/values/BlobValue.vue 90.9% 76.92% 100% 90.9% 30, 35, 110-115, 122-126, 147-148, 160-161
src/pages/AccountDetails.vue 95.37% 82.79% 100% 95.37% 42-46, 104-108, 385-386, 391-392, 399-400, 422-425, 455-456, 469-470
src/pages/ContractDetails.vue 98.33% 91.13% 100% 98.33% 74-78, 312
Generated in workflow #574

Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@svienot svienot merged commit c7dffa3 into main Nov 28, 2023
5 of 6 checks passed
@svienot svienot deleted the 00694-memo-display-v2 branch November 28, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect memo display.
2 participants