Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

00768 Streamline Hardhat Smart Contract Verification Process Similar to Sourcify #781

Merged
merged 1 commit into from
Nov 29, 2023
Merged

00768 Streamline Hardhat Smart Contract Verification Process Similar to Sourcify #781

merged 1 commit into from
Nov 29, 2023

Conversation

ericleponner
Copy link
Collaborator

Description:

Changes below enhance bytecode comparison done by Explorer.
SolcUtils.compareBytecode() method now detects when bytecode starts with 0x73 opcode and adjusts its comparison logic.

Related issue(s):

Fixes #768

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ericleponner ericleponner requested a review from svienot November 29, 2023 08:16
@ericleponner ericleponner self-assigned this Nov 29, 2023
@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 87.5% 33178 / 37919
🔵 Statements 87.5% 33178 / 37919
🔵 Functions 66.88% 820 / 1226
🔵 Branches 83.55% 3676 / 4400
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/utils/solc/SolcUtils.ts 80.64% 47.5% 66.66% 80.64% 34, 47-50, 93-94, 99-110, 113-124, 127-134, 171-179, 208-216, 262-263, 274
Generated in workflow #577

@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

svienot
svienot approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ericleponner ericleponner merged commit 2c997de into main Nov 29, 2023
5 of 6 checks passed
@ericleponner ericleponner deleted the 00768_library_placeholder branch November 29, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svienot svienot svienot approved these changes

Assignees

@ericleponner ericleponner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Streamline Hardhat Smart Contract Verification Process Similar to Sourcify
2 participants
@ericleponner @svienot