Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

00778 replace copy action by a navigation link #783

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Nov 29, 2023

Description:

  • Replace the Copyable Account ID in WalletInfo by a navigation link to the AccountDetails view (AccountLink)
  • Also dismiss the WalletInfo dialog when the user takes one of the available actions:
    • Navigate to one's account
    • Copy EVM Address
    • Switch accounts
  • Bring minor visual adjustments

In an ideal world, we would dismiss the dialog when the user clicks anywhere outside. This is not covered with this PR.

Related issue(s):

Fixes #778

Notes for reviewer:

Deployed on staging server.

@svienot svienot requested a review from ericleponner November 29, 2023 19:08
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 87.49% 33181 / 37926
🔵 Statements 87.49% 33181 / 37926
🔵 Functions 66.78% 820 / 1228
🔵 Branches 83.56% 3679 / 4403
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/Copyable.vue 94.04% 100% 50% 94.04% 60-64
src/components/TopNavBar.vue 95.73% 97.05% 58.33% 95.73% 47, 223-235, 245-246
src/components/wallet/WalletInfo.vue 94.8% 81.81% 50% 94.8% 53-55, 156-158, 186-189, 200-201
Generated in workflow #578

Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@svienot svienot merged commit 4044f6c into main Nov 29, 2023
5 of 6 checks passed
@svienot svienot deleted the 00778-Replace-Copy-action-by-a-navigation-link branch November 29, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Copy action by a navigation link in Connect pulldown window
2 participants