Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

00784 reactivity problem with the contract verification status #785

Merged
merged 2 commits into from
Nov 30, 2023
Merged

00784 reactivity problem with the contract verification status #785

merged 2 commits into from
Nov 30, 2023

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Nov 30, 2023

Description:

Adjust the reactivity of the ContractDetails view such that:

  • the (re)loading issue in 784 is fixed
  • we avoid the flashing effect: displaying NOT-VERIFIED when page is loaded and VERIFIED once the verification status has been obtained from sourcify.

Related issue(s):

Fixes #784

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@svienot svienot requested a review from ericleponner November 30, 2023 15:02
@svienot svienot self-assigned this Nov 30, 2023
@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 87.48% 33178 / 37925
🔵 Statements 87.48% 33178 / 37925
🔵 Functions 66.78% 820 / 1228
🔵 Branches 83.52% 3675 / 4400
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/contract/ContractByteCodeSection.vue 97.31% 81.81% 25% 97.31% 32-33, 149, 154-155
Generated in workflow #579

@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

ericleponner
ericleponner approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@svienot svienot merged commit af2e235 into main Nov 30, 2023
5 of 6 checks passed
@svienot svienot deleted the 00784-reactivity-problem-with-the-contract-verification-status branch November 30, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericleponner ericleponner ericleponner approved these changes

Assignees

@svienot svienot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reactivity problem with the contract verification status
2 participants
@svienot @ericleponner