Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: restyled and integrated event log component to contract detail page (#763) #788

Merged
merged 20 commits into from
Dec 4, 2023
Merged

update: restyled and integrated event log component to contract detail page (#763) #788

merged 20 commits into from
Dec 4, 2023

Conversation

quiet-node
Copy link
Member

Description:

  • restyled the event log component to adapt new proposed designs
  • created a new cache for a new mirror-node endpoint to retrieve event logs from a contract
  • integrated event log component to contract detail page
  • fixed unit tests to adapt new changes

Related issue(s):

Fixes #763

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node
feat: added cache to request logs by contractID
2a846f1 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node
feat: added ContractResultsLogsAnalyzer class
db19f48 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node
feat: brought contract result logs to ContractDetails page
8910175 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node
update: added optional indexed value to NameTypeValue class
5b64e0d 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node
update: updated ContractLogAnalyzer
fc359c2 
- added isContractVerified flag
- added fullLogSignature for a more descriptive event signature
- added signature hash to the list of args

Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node
feat: added ContractResultLogEntryV2 with the new designs from Figma
a1c8439 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node
feat: added new interfaces for HederaSchemas
e224bf4 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node
feat: added new ContractResultLogEntryV2 class to main layout
8eab905 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node
fix(test): fixed unit tests to adapt new changes from client components
91f5689 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node
style: added responsive style
6223b92 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node
update: updated ContractLog interface
bf6cce9 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node
update: added ContractResultsLogsByContractIdCache.instace.clear() in…
c4032ce 
… global CacheUtils.clearAll()

Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node
update: turned private on contractResultsLogResponse
664268d 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node
update: turned ContractLogAnalyzer.isContractVerified into a computed…
4fa286f 
… ref

Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node
update: reworked ContractResult interface
82aa637 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node
update: removed Method field in ContractResultLogEntry component
4afc4a4 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node
update: renamed ContractResultLogEntry V2 into main version
d52efc2 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node
fix(test): fixed unit test for ContractResultLogEntry
531b8b6 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node
style: added blue color to logs' type
d29c3b5 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node
fix(test): fixed unit test
dff574b 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node quiet-node added enhancement New feature or request smart contracts Features that involve smart contracts labels Dec 4, 2023
@quiet-node quiet-node self-assigned this Dec 4, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 87.57% 33546 / 38307
🔵 Statements 87.57% 33546 / 38307
🔵 Functions 66.99% 828 / 1236
🔵 Branches 83.39% 3701 / 4438
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/PropertyVertical.vue 89.58% 80% 100% 89.58% 28-37
src/components/contract/ContractResult.vue 100% 92.3% 100% 100%
src/components/contract/ContractResultLogEntry.vue 100% 93.75% 100% 100%
src/components/contract/ContractResultLogs.vue 98.66% 94.11% 50% 98.66% 108-109
src/components/values/FunctionValue.vue 98.9% 40% 100% 98.9% 33
src/pages/ContractDetails.vue 98.39% 91.35% 100% 98.39% 74-78, 317
src/pages/TransactionDetails.vue 99.14% 94.01% 100% 99.14% 208, 350, 420-421
src/schemas/HederaSchemas.ts 97.9% 64.28% 100% 97.9% 296-297, 664, 778-779, 781-782, 798-799, 801-808
src/utils/analyzer/ContractLogAnalyzer.ts 96.69% 68.75% 100% 96.69% 79-80, 114-115
src/utils/analyzer/ContractResultsLogsAnalyzer.ts 96.96% 80% 100% 96.96% 60-61
src/utils/analyzer/FunctionCallAnalyzer.ts 93.35% 79.68% 100% 93.35% 134-142, 172, 228-235
src/utils/cache/CacheUtils.ts 100% 100% 100% 100%
src/utils/cache/ContractResultsLogsByContractIdCache.ts 94.23% 50% 100% 94.23% 41, 46-47
Generated in workflow #583

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 18 Code Smells

0.0% 0.0% Coverage
0.4% 0.4% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@quiet-node quiet-node requested review from ericleponner and svienot and removed request for ericleponner December 4, 2023 18:38
ericleponner
ericleponner approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@quiet-node quiet-node merged commit c5df8dc into main Dec 4, 2023
5 of 6 checks passed
@quiet-node quiet-node deleted the 763-(phase-2)-Restyle-and-bring-event-logs-component-to-contract-level branch December 4, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericleponner ericleponner ericleponner approved these changes

@svienot svienot Awaiting requested review from svienot svienot is a code owner

Assignees

@quiet-node quiet-node

Labels
enhancement New feature or request smart contracts Features that involve smart contracts
Projects
Smart Contract Sprint Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restyle and bring event logs component to contract level
2 participants
@quiet-node @ericleponner