Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 00786 ContractVerificationDialog.dialogTitle must be a computed value. #793

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

ericleponner
Copy link
Collaborator

Description:

Changes below fix Contract Verification dialog : dialogTitle must be a computed value.

Related issue(s):

Fixes #786

Notes for reviewer:

See instructions to reproduce and verify from #786

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ericleponner ericleponner requested a review from svienot December 8, 2023 18:16
Copy link

github-actions bot commented Dec 8, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 87.57% 33546 / 38307
🔵 Statements 87.57% 33546 / 38307
🔵 Functions 66.99% 828 / 1236
🔵 Branches 83.4% 3703 / 4440
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/verification/ContractVerificationDialog.vue 66.95% 75% 5% 66.95% 51, 189-193, 196-202, 209-211, 223-227, 230-235, 254-267, 276, 278, 280-315, 323-324, 332-334, 346-406, 409-412, 424-429
Generated in workflow #586

Copy link

sonarqubecloud bot commented Dec 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell D 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ericleponner ericleponner merged commit 23dea30 into main Dec 11, 2023
5 of 6 checks passed
@ericleponner ericleponner deleted the 00786_wrong_contract_id branch December 11, 2023 07:54
@ericleponner
Copy link
Collaborator Author

Bug number is #789 (not #786)… :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants