Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: moving ethers library from 5.7.2 to 6.9.0. #802

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

ericleponner
Copy link
Collaborator

Description:
Changes below upgrade ethers library from 5.7.2 to 6.9.0.

Related issue(s):

None

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ericleponner ericleponner requested a review from svienot December 13, 2023 18:58
@ericleponner ericleponner self-assigned this Dec 13, 2023
Copy link

github-actions bot commented Dec 13, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 87.56% 33560 / 38328
🔵 Statements 87.56% 33560 / 38328
🔵 Functions 66.99% 828 / 1236
🔵 Branches 83.41% 3708 / 4445
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/values/FunctionValue.vue 98.9% 40% 100% 98.9% 33
src/schemas/HederaUtils.ts 80.46% 75.34% 82.35% 80.46% 29-31, 37-38, 46-47, 70-71, 81-84, 94-97, 102-103, 145-154, 156-157, 163-164, 207-215
src/utils/analyzer/ContractAnalyzer.ts 85.03% 84.31% 87.5% 85.03% 72-82, 102-103, 113, 127, 139-150, 191-195, 212-213, 226-227, 240-241
src/utils/analyzer/ContractLogAnalyzer.ts 96.69% 68.75% 100% 96.69% 79-80, 114-115
src/utils/analyzer/FunctionCallAnalyzer.ts 92.94% 80.95% 100% 92.94% 134-142, 172, 228-235
src/utils/wallet/WalletDriver_Metamask.ts 34.91% 100% 13.33% 34.91% 65-94, 97-99, 102-125, 128-151, 154-180, 183-184, 193-216, 219-231, 235-257, 260-265, 279-281, 283-295
Generated in workflow #596

svienot
svienot previously approved these changes Dec 14, 2023
Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ericleponner ericleponner merged commit de6a503 into main Dec 14, 2023
6 checks passed
@ericleponner ericleponner deleted the migrate_to_ethers_v6 branch December 14, 2023 11:10
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants