chore: move to latest release of @bladelabs/blade-web3.js. #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Le Ponner <[email protected]>
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
ericleponner
changed the title
|
svienot
approved these changes
Dec 21, 2023
svienot
added a commit
that referenced
this pull request
Jan 8, 2024
)" This reverts commit c588502.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes below update release of @blandelabs/blade-web3 from 1.1.1 to 1.2.2.
Straight move to
1.2.2release breaks all unit tests.After investigations, it turns out that
import @blandelabs/blade-web3.jsnow executes some code with dependency onwindow.matchMedia(). Althoughvitestis setup to mockwindow.matchMedia()(seeglobalSetup.js), it does not prevent crashing.To avoid that,
WalletDriver_Bladeclass now performs a dynamic import of@blandelabs/blade-web3.js.Related issue(s):
None
Checklist