-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Explorer could interpret Solidity method selectors #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ually separates function selector from input args). Signed-off-by: Eric Le Ponner <[email protected]>
…t-service repo. Signed-off-by: Eric Le Ponner <[email protected]>
Signed-off-by: Eric Le Ponner <[email protected]>
Signed-off-by: Eric Le Ponner <[email protected]>
Signed-off-by: Eric Le Ponner <[email protected]>
Signed-off-by: Eric Le Ponner <[email protected]>
…utArgsOnly. Signed-off-by: Eric Le Ponner <[email protected]>
Signed-off-by: Eric Le Ponner <[email protected]>
Signed-off-by: Eric Le Ponner <[email protected]>
Coverage Report
File Coverage
|
Quality Gate failedFailed conditions 0.0% Coverage on New Code (required ≥ 80%) |
svienot
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
With changes below, Explorer now queries 4byte.directory and tries to decode call input/output.
Contract Result
andCall Trace
sections inTransaction Details
are now able to display decoded input and output even if corresponding contract is unverified.Changes also include additional unit tests for
FunctionCallAnalyzer
class.Note: Event decoding is not handled by these changes ; this will be done in a second phase.
Related issue(s):
Fixes #696
Notes for reviewer:
This transaction gives a pretty good view of the feature (see
Call Trace
section).Checklist