Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misc cosmetic fixes #882

Merged
merged 2 commits into from
Jan 31, 2024
Merged

fix: misc cosmetic fixes #882

merged 2 commits into from
Jan 31, 2024

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Jan 30, 2024

Description:

A couple purely cosmetic changes:

  • accountAllowances -> Account Allowances in ApproveAllowanceSection
  • Suppress unwanted <div> elements which break the CSS spacing for DashboardCard

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 85.25% 34222 / 40143
🔵 Statements 85.25% 34222 / 40143
🔵 Functions 65.21% 810 / 1242
🔵 Branches 84.17% 3834 / 4555
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/allowances/ApproveAllowanceSection.vue 81.44% 80% 11.11% 81.44% 110-111, 114-116, 120-122, 149-156, 159-163, 166-170, 173-177, 180-189
src/components/contract/ContractResult.vue 100% 88.88% 100% 100%
src/components/topic/TopicMessage.vue 100% 100% 100% 100%
Generated in workflow #693

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@svienot svienot marked this pull request as ready for review January 30, 2024 21:57
@svienot svienot requested a review from ericleponner January 30, 2024 21:57
@svienot svienot self-assigned this Jan 30, 2024
@svienot svienot changed the title fix: misc cosmet fix: misc cosmetic fixes Jan 30, 2024
Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@svienot svienot merged commit e3cd2f8 into main Jan 31, 2024
6 of 7 checks passed
@svienot svienot deleted the misc-fixes branch January 31, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants