Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: tentative fix for random break in unit tests #883

Merged
merged 1 commit into from
Jan 31, 2024
Merged

chore: tentative fix for random break in unit tests #883

merged 1 commit into from
Jan 31, 2024

Conversation

ericleponner
Copy link
Collaborator

Description:

Changes below fix MetadataCache.clear() : this is suspected to be root cause of random breaks in unit tests.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ericleponner
MarketDataCache.clear() now invokes EntityLoader.requestLoad() only w…
945af00 
…hen mounted (else it breaks EntityLoader invariant).

Signed-off-by: Eric Le Ponner <[email protected]>
@ericleponner ericleponner requested a review from svienot January 31, 2024 18:48
@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 85.38% 34464 / 40364
🔵 Statements 85.38% 34464 / 40364
🔵 Functions 65.2% 817 / 1253
🔵 Branches 84.16% 3858 / 4584
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/dashboard/MarketDataCache.ts 100% 100% 100% 100%
src/utils/loader/AutoRefreshLoader.ts 97.34% 93.75% 100% 97.34% 65, 68-69
Generated in workflow #697

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

svienot
svienot approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericleponner ericleponner merged commit 5211203 into main Jan 31, 2024
10 checks passed
@ericleponner ericleponner deleted the random-break-in-unit-test-fix branch January 31, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svienot svienot svienot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericleponner @svienot