Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactoring around name services #886

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

ericleponner
Copy link
Collaborator

Description:
Changes below perform a few renamings around naming service in SearchRequest.ts.
Goal is to make easier integration of other name services (next to KNS).

Related issue(s):

None

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ericleponner ericleponner requested a review from svienot February 1, 2024 12:03
Copy link

github-actions bot commented Feb 1, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 85.38% 34467 / 40367
🔵 Statements 85.38% 34467 / 40367
🔵 Functions 65.2% 817 / 1253
🔵 Branches 84.15% 3857 / 4583
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/utils/RouteManager.ts 73.98% 95.52% 66.66% 73.98% 64, 86-89, 159-168, 171-180, 198-199, 218-227, 234-237, 240-241, 262-271, 274-278, 281-285, 288-297, 300-309, 320-329, 340-349, 360-369, 380-389, 396-401, 404-405, 416-417, 456-457
src/utils/SearchRequest.ts 92% 80.82% 100% 92% 122-128, 140-141, 162-165, 194-196, 202-203, 223-224, 306-309, 340-341, 346-347
Generated in workflow #698

Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@ericleponner ericleponner merged commit d21814c into main Feb 1, 2024
6 of 7 checks passed
@ericleponner ericleponner deleted the refactoring-naming-service branch February 1, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants