Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrating @kabuto-sh/ns release to 0.13.2 #887

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

ericleponner
Copy link
Collaborator

Description:

Changes below migrate KNS api to 0.13.2.
They also add a e2e test case to SearchBar.cy.ts to validate KNS integration.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ericleponner ericleponner requested a review from svienot February 1, 2024 17:27
Copy link

github-actions bot commented Feb 1, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 85.38% 34467 / 40367
🔵 Statements 85.38% 34467 / 40367
🔵 Functions 65.2% 817 / 1253
🔵 Branches 84.15% 3860 / 4587
File CoverageNo changed files found.
Generated in workflow #699

Copy link

sonarqubecloud bot commented Feb 1, 2024

Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks just fine!

@ericleponner ericleponner merged commit 43e9bd0 into main Feb 1, 2024
7 checks passed
@ericleponner ericleponner deleted the migrating_to_latest_kns branch February 1, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants