Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor inline balances #892

Merged
merged 6 commits into from
Feb 12, 2024
Merged

chore: Refactor inline balances #892

merged 6 commits into from
Feb 12, 2024

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Feb 12, 2024

Description:

Refactoring of the display of inline balances (+ age of balance state) by means of InlineBalancesValue component, used by AccountDetails and ContractDetails views.

Notes for reviewer:

Deployed on staging server.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@svienot svienot requested a review from ericleponner February 12, 2024 14:59
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 85.45% 34607 / 40495
🔵 Statements 85.45% 34607 / 40495
🔵 Functions 65.25% 819 / 1255
🔵 Branches 84.37% 3871 / 4588
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/values/InlineBalancesValue.vue 98.71% 85.18% 100% 98.71% 103, 105
src/pages/AccountDetails.vue 97.27% 83.69% 100% 97.27% 48-52, 369-370, 383-384, 418-419, 432-433
src/pages/ContractDetails.vue 100% 94.66% 100% 100%
src/utils/analyzer/BalanceAnalyzer.ts 96.29% 92.59% 100% 96.29% 54-56, 89
Generated in workflow #707

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
43.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@svienot svienot merged commit 9f6e102 into main Feb 12, 2024
6 of 7 checks passed
@svienot svienot deleted the refactor-inline-balances branch February 12, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants