fix: provided a key attribute to force refresh prism component on re-renders (#894) #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…renders (#894) Signed-off-by: Logan Nguyen <[email protected]>
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
ericleponner
requested changes
Feb 15, 2024
Signed-off-by: Logan Nguyen <[email protected]>
quiet-node
deleted the
894-navigating-by-verified-contract-evm-address-results-in-previous-contracts-source-code
branch
|
svienot
pushed a commit
that referenced
this pull request
Feb 15, 2024
…renders (#894) (#896) Signed-off-by: Logan Nguyen <[email protected]> (cherry picked from commit 26ff05f)
quiet-node
restored the
894-navigating-by-verified-contract-evm-address-results-in-previous-contracts-source-code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently on Hashscan, we utilize an external library
prismjsto display the solidity smart contract. Thisprismjscomponent wraps around the source solidity file as its child component. However, theprismjscomponent does not update its child components on re-renders. Therefore, this PR pushes in a fix that forces the prism component to refresh by supplying it with a dynamic uniquekeyattribute.Related issue(s):
Fixes #894
Notes for reviewer:
Checklist