Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add toggle to display recent verified contracts #897

Closed
wants to merge 8 commits into from

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Feb 16, 2024

Description:

Add toggle to choose between display of all vs. only verified contracts in the Contracts page.

Related issue(s):

Fixes #884

Notes for reviewer:

In review on staging server.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@svienot svienot requested a review from ericleponner February 16, 2024 02:02
@svienot svienot self-assigned this Feb 16, 2024
@svienot svienot force-pushed the 00884-recent-verified-contracts branch from 6c3ef9e to 235647d Compare February 16, 2024 02:03
Copy link

github-actions bot commented Feb 16, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 84.84% 35145 / 41422
🔵 Statements 84.84% 35145 / 41422
🔵 Functions 64.7% 825 / 1275
🔵 Branches 84.37% 3877 / 4595
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/EmptyTable.vue 100% 100% 100% 100%
src/components/PlayPauseButton.vue 88.52% 100% 33.33% 88.52% 87, 93-105
src/components/contract/ContractTable.vue 97.26% 100% 33.33% 97.26% 120-123
src/components/contract/VerifiedContractTable.vue 81.61% 100% 0% 81.61% 103-127
src/pages/Contracts.vue 96.96% 55.55% 33.33% 96.96% 39, 48, 79-80
src/schemas/NetworkRegistry.ts 91.24% 78.57% 88% 91.24% 79-80, 85-86, 122-123, 141-142, 145-147, 150-151, 208, 212-219, 263-265, 269-271, 273, 280-281
src/utils/cache/CacheUtils.ts 100% 100% 100% 100%
src/utils/cache/VerifiedContractsCache.ts 46.56% 100% 42.85% 46.56% 44-45, 57-117, 135-140, 143-149, 158-163, 166-173, 176-177, 180-188
src/utils/cache/base/SingletonCache.ts 97.33% 100% 88.88% 97.33% 52-53
src/utils/table/TableController.ts 91.08% 93.84% 85.18% 91.08% 106-108, 144-145, 156-172, 209-210, 235-236, 249-254
Generated in workflow #716

@svienot svienot force-pushed the 00884-recent-verified-contracts branch from 235647d to 4ebe2c1 Compare February 20, 2024 14:52
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@svienot svienot marked this pull request as draft March 1, 2024 14:41
@svienot svienot closed this Mar 4, 2024
@svienot svienot deleted the 00884-recent-verified-contracts branch March 4, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add toggle in Recent Contracts view to display all contracts or only verified contracts
1 participant