Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated package dependencies using npm update --save #900

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Conversation

ericleponner
Copy link
Collaborator

Description:

Changes below update package dependencies using npm update --save.

Straight move to this new components breaks all e2e tests.
Each test reports the following error:

5:06:21 PM [vite] Internal server error: Failed to resolve import "@/utils/wallet//WalletDriver_Brave" from "src/utils/wallet/WalletManager.ts". Does the file exist?
  Plugin: vite:import-analysis
  File: /hedera-mirror-node-explorer/src/utils/wallet/WalletManager.ts:31:33
  15 |  import { WalletDriver_Ethereum } from "@/utils/wallet/WalletDriver_Ethereum";
  16 |  import { WalletDriver_Coinbase } from "@/utils/wallet/WalletDriver_Coinbase";
  17 |  import { WalletDriver_Brave } from "@/utils/wallet//WalletDriver_Brave";
     |                                      ^
  18 |  export class WalletManager {
  19 |    routeManager;
      at formatError (file:///Users/eric/Documents/Hedera/WS/hedera-mirror-node-explorer/node_modules/vite/dist/node/chunks/dep-stQc5rCc.js:50500:46)
      at TransformContext.error (file:///Users/eric/Documents/Hedera/WS/hedera-mirror-node-explorer/node_modules/vite/dist/node/chunks/dep-stQc5rCc.js:50494:19)
      at normalizeUrl (file:///Users/eric/Documents/Hedera/WS/hedera-mirror-node-explorer/node_modules/vite/dist/node/chunks/dep-stQc5rCc.js:65562:33)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
      at async file:///Users/eric/Documents/Hedera/WS/hedera-mirror-node-explorer/node_modules/vite/dist/node/chunks/dep-stQc5rCc.js:65717:47
      at async Promise.all (index 11)
      at async TransformContext.transform (file:///Users/eric/Documents/Hedera/WS/hedera-mirror-node-explorer/node_modules/vite/dist/node/chunks/dep-stQc5rCc.js:65638:13)
      at async Object.transform (file:///Users/eric/Documents/Hedera/WS/hedera-mirror-node-explorer/node_modules/vite/dist/node/chunks/dep-stQc5rCc.js:50809:30)
      at async loadAndTransform (file:///Users/eric/Documents/Hedera/WS/hedera-mirror-node-explorer/node_modules/vite/dist/node/chunks/dep-stQc5rCc.js:53582:29)
      at async viteTransformMiddleware (file:///Users/eric/Documents/Hedera/WS/hedera-mirror-node-explorer/node_modules/vite/dist/node/chunks/dep-stQc5rCc.js:63377:32)
    1) should navigate from table to account details

Same symptoms are reported here: vitejs/vite#15784.
Recommended workaround (cachedChecks: false in vite.config.ts) fixes the pb.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ericleponner ericleponner requested a review from svienot February 19, 2024 16:17
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 85.02% 34900 / 41045
🔵 Statements 85.02% 34900 / 41045
🔵 Functions 65.15% 819 / 1257
🔵 Branches 84.4% 3870 / 4585
File CoverageNo changed files found.
Generated in workflow #715

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@svienot svienot merged commit 352855d into main Feb 20, 2024
10 checks passed
@svienot svienot deleted the npm_update branch February 20, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants