Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: account Transactions time filterable #909

Merged
merged 12 commits into from
Mar 18, 2024
Merged

feat: account Transactions time filterable #909

merged 12 commits into from
Mar 18, 2024

Conversation

Sheng-Long
Copy link
Contributor

@Sheng-Long Sheng-Long commented Feb 28, 2024 •
edited
Loading

Description:
Allows account transactions to be filtered by time

Related issue(s):
#907

Fixes #
Adds time filter

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@Sheng-Long Sheng-Long force-pushed the 00907-filter-transactions-by-time branch 2 times, most recently from 49ddd04 to 932def8 Compare February 28, 2024 08:31
@Sheng-Long Sheng-Long changed the title fix: allow account transactions to be filtered by time Account Transactions time filterable and length modifiable Feb 28, 2024
@Sheng-Long Sheng-Long force-pushed the 00907-filter-transactions-by-time branch 4 times, most recently from 979b560 to c783b2a Compare March 4, 2024 22:01
@Sheng-Long
Copy link
Contributor Author

I'm not sure why this unit test is now failing, it seems to be failing at expect(tc.totalRowCount.value).toBe(0), but I don't believe the added/modified code should affect that.

@Sheng-Long Sheng-Long force-pushed the 00907-filter-transactions-by-time branch from c4556fa to 84433ec Compare March 7, 2024 21:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 83.15% 35505 / 42697
🔵 Statements 83.15% 35505 / 42697
🔵 Functions 63.93% 835 / 1306
🔵 Branches 84.14% 3911 / 4648
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/DateTimePicker.vue 81.05% 100% 0% 81.05% 55-72
src/pages/AccountDetails.vue 45.75% 81.81% 20% 45.75% 1-264, 376-382, 386-388, 426-427, 432-433, 450-452
src/utils/table/TableController.ts 89.45% 95.58% 82.14% 89.45% 108-110, 136-142, 155-156, 167-183, 220-221, 246-247, 260-265
Generated in workflow #775

@Sheng-Long Sheng-Long force-pushed the 00907-filter-transactions-by-time branch 2 times, most recently from aa59774 to ca41950 Compare March 7, 2024 21:24
@Sheng-Long
fix: allow account transactions to be filtered by time
e7e7e5e 
Signed-off-by: Tim Schmidt <[email protected]>
@Sheng-Long
fix: allow for longer list of transactions in account details
17f9ab3 
Signed-off-by: Tim Schmidt <[email protected]>
@Sheng-Long
fix: fix timestamp decimals for unknown change to api call
7d01a16 
Signed-off-by: Tim Schmidt <[email protected]>
@Sheng-Long
fix: simplify per page changes
060fc04 
Signed-off-by: Tim Schmidt <[email protected]>
@Sheng-Long
fix: add clear behavior to datetimepicker
ce1691a 
Signed-off-by: Tim Schmidt <[email protected]>
@Sheng-Long
fix: fix e2e test
19ca9fe 
Signed-off-by: Tim Schmidt <[email protected]>
@Sheng-Long
fix: remove page selector, in another PR
7f4c17b 
Signed-off-by: Tim Schmidt <[email protected]>
@Sheng-Long
fix: add selector for Latest/jump to date
739c01c 
Signed-off-by: Tim Schmidt <[email protected]>
@Sheng-Long
fix: styling
de233c2 
Signed-off-by: Tim Schmidt <[email protected]>
@Sheng-Long Sheng-Long force-pushed the 00907-filter-transactions-by-time branch from f21c0ba to 9459259 Compare March 12, 2024 23:26
@Sheng-Long Sheng-Long changed the title Account Transactions time filterable and length modifiable Account Transactions time filterable Mar 12, 2024
@Sheng-Long Sheng-Long force-pushed the 00907-filter-transactions-by-time branch from 9459259 to 2213b21 Compare March 12, 2024 23:37
@Sheng-Long Sheng-Long force-pushed the 00907-filter-transactions-by-time branch from 2213b21 to a987c25 Compare March 12, 2024 23:43
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

svienot
svienot approved these changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@ericleponner ericleponner merged commit fbbcc5c into main Mar 18, 2024
6 of 7 checks passed
@ericleponner ericleponner deleted the 00907-filter-transactions-by-time branch March 18, 2024 15:29
@ericleponner ericleponner changed the title Account Transactions time filterable feat: account Transactions time filterable Mar 18, 2024
@ericleponner ericleponner mentioned this pull request Mar 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svienot svienot svienot approved these changes

@ericleponner ericleponner Awaiting requested review from ericleponner ericleponner is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sheng-Long @svienot @ericleponner