Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional spec support in rest Java #10118

Merged
merged 5 commits into from
Jan 17, 2025

Conversation

jnels124
Copy link
Contributor

@jnels124 jnels124 commented Jan 13, 2025

Description:

  • add support for contract spec tests
  • add support for entity stake spec tests
  • add support for history entities
  • various bug fixes

Related issue(s):

Fixes #9047

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@jnels124 jnels124 added enhancement Type: New feature test Test infrastructure, automated tests required, etc labels Jan 13, 2025
@jnels124 jnels124 added this to the 0.122.0 milestone Jan 13, 2025
@jnels124 jnels124 self-assigned this Jan 13, 2025
@jnels124 jnels124 linked an issue Jan 13, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.30%. Comparing base (c1fa7bc) to head (18ee394).
Report is 33 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10118      +/-   ##
============================================
+ Coverage     92.21%   92.30%   +0.09%     
+ Complexity     7858     7792      -66     
============================================
  Files           956      941      -15     
  Lines         32938    32765     -173     
  Branches       4151     4143       -8     
============================================
- Hits          30373    30243     -130     
+ Misses         1588     1547      -41     
+ Partials        977      975       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jnels124 jnels124 force-pushed the 9047-support-remaining-basic-specs branch 2 times, most recently from b40bda0 to cce0cd4 Compare January 15, 2025 00:14
@jnels124 jnels124 force-pushed the 9047-support-remaining-basic-specs branch from cce0cd4 to a6d8c98 Compare January 15, 2025 00:15
@jnels124 jnels124 marked this pull request as ready for review January 15, 2025 15:26
@jnels124 jnels124 requested a review from a team as a code owner January 15, 2025 15:26
Signed-off-by: Jesse Nelson <[email protected]>
Signed-off-by: Jesse Nelson <[email protected]>
Signed-off-by: Jesse Nelson <[email protected]>
@jnels124 jnels124 force-pushed the 9047-support-remaining-basic-specs branch from 3f679e7 to 18ee394 Compare January 17, 2025 00:57
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnels124 jnels124 merged commit a901bf9 into main Jan 17, 2025
34 of 36 checks passed
@jnels124 jnels124 deleted the 9047-support-remaining-basic-specs branch January 17, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature test Test infrastructure, automated tests required, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support remaining basic specs
3 participants