Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump hedera-app to 0.58.3 #10126

Closed
wants to merge 4 commits into from
Closed

Bump hedera-app to 0.58.3 #10126

wants to merge 4 commits into from

Conversation

kselveliev
Copy link
Contributor

Description:
This PR bumps hedera-app to 0.58.3 from 0.57.2
Main changes: build was failing with Could not find com.hedera.cryptography:hedera-cryptography-bls:0.1.1-SNAPSHOT
had to add the snapshot repository to make it work so new change is added:

repositories {
    maven {
        url = uri("https://oss.sonatype.org/content/repositories/snapshots")
    }
}

Other upstream changes:
Deprecation of CRYPTOADDLIVEHASH and CRYPTODELETELIVEHASH which are removed in this PR.

This PR modifies:
build.gradle.kts - bump hedera app and add the snapshot version com.hedera.cryptography:hedera-cryptography-bls:0.1.1-SNAPSHOT

build.gradle.kts - web3 - add snapshot repository link

MiscUtils - removed CRYPTOADDLIVEHASH and CRYPTODELETELIVEHASH which are marked as deprecated

The rest of the changes are made to accomodate modified classes for the modularized state which were changed upstream.

-->

Related issue(s):

Fixes #10125

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Kristiyan Selveliev <[email protected]>
@kselveliev kselveliev added dependencies Type: Pull requests that update a dependency file web3 Area: Web3 API modularizedEVM labels Jan 14, 2025
@kselveliev kselveliev self-assigned this Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.34%. Comparing base (2833b87) to head (bd5fa04).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...main/java/com/hedera/services/utils/MiscUtils.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10126      +/-   ##
============================================
- Coverage     92.38%   92.34%   -0.05%     
- Complexity     5566     7755    +2189     
============================================
  Files           723      934     +211     
  Lines         24634    32458    +7824     
  Branches       3222     4110     +888     
============================================
+ Hits          22759    29972    +7213     
- Misses         1116     1517     +401     
- Partials        759      969     +210     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kristiyan Selveliev <[email protected]>
@steven-sheehy steven-sheehy added this to the 0.122.0 milestone Jan 14, 2025
@kselveliev kselveliev marked this pull request as ready for review January 15, 2025 09:29
@kselveliev kselveliev requested a review from a team as a code owner January 15, 2025 09:29
Signed-off-by: Kristiyan Selveliev <[email protected]>
Copy link
Contributor

@bilyana-gospodinova bilyana-gospodinova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy
Copy link
Member

One commit is not gpg signed

@@ -31,6 +31,8 @@ plugins {
// dependency
val headlongVersion = "6.1.1"

repositories { maven { url = uri("https://oss.sonatype.org/content/repositories/snapshots") } }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add a comment that this is added temporarily for com.hedera.cryptography snapshot dependencies.

@kselveliev
Copy link
Contributor Author

Due to gpg issue copied this pr into a new one properly gpg signed -> #10139

@kselveliev kselveliev closed this Jan 15, 2025
@kselveliev kselveliev mentioned this pull request Jan 15, 2025
2 tasks
@steven-sheehy steven-sheehy deleted the 10125-bump-hedera-app-58.3 branch January 15, 2025 16:04
@steven-sheehy steven-sheehy removed this from the 0.122.0 milestone Jan 15, 2025
steven-sheehy pushed a commit that referenced this pull request Jan 15, 2025
Copy of #10126
This PR bumps hedera-app to 0.58.3 from 0.57.2
Main changes: build was failing with Could not find com.hedera.cryptography:hedera-cryptography-bls:0.1.1-SNAPSHOT
had to add the snapshot repository to make it work so new change is added:

repositories {
    maven {
        url = uri("https://oss.sonatype.org/content/repositories/snapshots")
    }
}

Other upstream changes:
Deprecation of CRYPTOADDLIVEHASH and CRYPTODELETELIVEHASH which are removed in this PR.

This PR modifies:
build.gradle.kts - bump hedera app and add the snapshot version com.hedera.cryptography:hedera-cryptography-bls:0.1.1-SNAPSHOT

build.gradle.kts - web3 - add snapshot repository link

MiscUtils - removed CRYPTOADDLIVEHASH and CRYPTODELETELIVEHASH which are marked as deprecated

The rest of the changes are made to accomodate modified classes for the modularized state which were changed upstream.

---------

Signed-off-by: Kristiyan Selveliev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Type: Pull requests that update a dependency file modularizedEVM web3 Area: Web3 API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump hedera-app to 58.3 in web3
3 participants