-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump hedera-app to 0.58.3 #10126
Bump hedera-app to 0.58.3 #10126
Conversation
Signed-off-by: Kristiyan Selveliev <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10126 +/- ##
============================================
- Coverage 92.38% 92.34% -0.05%
- Complexity 5566 7755 +2189
============================================
Files 723 934 +211
Lines 24634 32458 +7824
Branches 3222 4110 +888
============================================
+ Hits 22759 29972 +7213
- Misses 1116 1517 +401
- Partials 759 969 +210 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kristiyan Selveliev <[email protected]>
Signed-off-by: Kristiyan Selveliev <[email protected]>
...ra-mirror-web3/src/main/java/com/hedera/mirror/web3/state/components/SchemaRegistryImpl.java
Outdated
Show resolved
Hide resolved
...mirror-web3/src/main/java/com/hedera/mirror/web3/state/TokenRelationshipReadableKVState.java
Show resolved
Hide resolved
Signed-off-by: Kristiyan Selveliev <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
One commit is not gpg signed |
@@ -31,6 +31,8 @@ plugins { | |||
// dependency | |||
val headlongVersion = "6.1.1" | |||
|
|||
repositories { maven { url = uri("https://oss.sonatype.org/content/repositories/snapshots") } } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add a comment that this is added temporarily for com.hedera.cryptography
snapshot dependencies.
Due to gpg issue copied this pr into a new one properly gpg signed -> #10139 |
Copy of #10126 This PR bumps hedera-app to 0.58.3 from 0.57.2 Main changes: build was failing with Could not find com.hedera.cryptography:hedera-cryptography-bls:0.1.1-SNAPSHOT had to add the snapshot repository to make it work so new change is added: repositories { maven { url = uri("https://oss.sonatype.org/content/repositories/snapshots") } } Other upstream changes: Deprecation of CRYPTOADDLIVEHASH and CRYPTODELETELIVEHASH which are removed in this PR. This PR modifies: build.gradle.kts - bump hedera app and add the snapshot version com.hedera.cryptography:hedera-cryptography-bls:0.1.1-SNAPSHOT build.gradle.kts - web3 - add snapshot repository link MiscUtils - removed CRYPTOADDLIVEHASH and CRYPTODELETELIVEHASH which are marked as deprecated The rest of the changes are made to accomodate modified classes for the modularized state which were changed upstream. --------- Signed-off-by: Kristiyan Selveliev <[email protected]>
Description:
This PR bumps hedera-app to 0.58.3 from 0.57.2
Main changes: build was failing with
Could not find com.hedera.cryptography:hedera-cryptography-bls:0.1.1-SNAPSHOT
had to add the snapshot repository to make it work so new change is added:
Other upstream changes:
Deprecation of CRYPTOADDLIVEHASH and CRYPTODELETELIVEHASH which are removed in this PR.
This PR modifies:
build.gradle.kts - bump hedera app and add the snapshot version com.hedera.cryptography:hedera-cryptography-bls:0.1.1-SNAPSHOT
build.gradle.kts - web3 - add snapshot repository link
MiscUtils - removed CRYPTOADDLIVEHASH and CRYPTODELETELIVEHASH which are marked as deprecated
The rest of the changes are made to accomodate modified classes for the modularized state which were changed upstream.
-->
Related issue(s):
Fixes #10125
Notes for reviewer:
Checklist