Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add feature flag for the admin_key in the get network nodes" #10138

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

steven-sheehy
Copy link
Member

Description:

Revert "Add feature flag for the admin_key in the get network nodes response …"

This reverts commit e420a25.

Related issue(s):

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…esponse" (#10131)

Revert "Add feature flag for the admin_key in the get network nodes response …"

This reverts commit e420a25.

Signed-off-by: Steven Sheehy <[email protected]>
@steven-sheehy steven-sheehy added enhancement Type: New feature rest Area: REST API labels Jan 15, 2025
@steven-sheehy steven-sheehy self-assigned this Jan 15, 2025
@steven-sheehy steven-sheehy requested a review from a team as a code owner January 15, 2025 15:24
Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit f09e0bc into release/0.121 Jan 15, 2025
34 checks passed
@steven-sheehy steven-sheehy deleted the revert-9875 branch January 15, 2025 15:48
@steven-sheehy steven-sheehy added this to the 0.121.2 milestone Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.24%. Comparing base (9f44ac9) to head (1527ccd).
Report is 2 commits behind head on release/0.121.

Additional details and impacted files
@@               Coverage Diff                @@
##             release/0.121   #10138   +/-   ##
================================================
  Coverage            92.23%   92.24%           
  Complexity            7857     7857           
================================================
  Files                  956      956           
  Lines                32921    32920    -1     
  Branches              4154     4153    -1     
================================================
  Hits                 30366    30366           
  Misses                1579     1579           
+ Partials               976      975    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature rest Area: REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants