Fix hbar and token transfer tests #10152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kristiyan Selveliev <[email protected]>
kselveliev
requested review from
steven-sheehy,
bilyana-gospodinova and
sdimitrov9
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10152 +/- ##
============================================
- Coverage 92.51% 92.30% -0.21%
- Complexity 5470 7821 +2351
============================================
Files 710 947 +237
Lines 24413 32847 +8434
Branches 3201 4151 +950
============================================
+ Hits 22586 30321 +7735
- Misses 1072 1550 +478
- Partials 755 976 +221 ☔ View full report in Codecov by Sentry. |
.../test/java/com/hedera/mirror/web3/service/ContractCallServicePrecompileModificationTest.java
Outdated
Show resolved
Hide resolved
.../test/java/com/hedera/mirror/web3/service/ContractCallServicePrecompileModificationTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kristiyan Selveliev <[email protected]>
Signed-off-by: Kristiyan Selveliev <[email protected]>
steven-sheehy
approved these changes
Jan 17, 2025
2 tasks
Signed-off-by: Kristiyan Selveliev <[email protected]>
steven-sheehy
approved these changes
Jan 17, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This Pr fixes
cryptoTransferHbars,cryptoTransferTokenandcryptoTransferHbarsAndTokentest in ContractCallServicePrecompileModificationTest.Those test were failing in the opcode assertion calls.
In the opcode flow we are always having a timestamp in the request.
So even if the timestamp is pretty similar to the latest case token balance and account balance are calculated with the historical queries. This PR adds the token and account balance setup for opcode flow.
Having the blueprint of the token and account balance, now we can fix other opcode test failure which are failing with insufficient payer or token balance.
This PR modifies ... in order to support ...
ContractCallServicePrecompileModificationTest- add token and account balance setup for transfer testsRelated issue(s):
Fixes #
Notes for reviewer:
3342 tests completed, 295 failed, 6 skipped
Checklist