Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datasource to rest for primary sql instance #10153

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jnels124
Copy link
Contributor

@jnels124 jnels124 commented Jan 16, 2025

Description:

  • add datasource for primary instance

Related issue(s):

Fixes #10074

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@jnels124 jnels124 added bug Type: Something isn't working rest Area: REST API labels Jan 16, 2025
@jnels124 jnels124 added this to the 0.122.0 milestone Jan 16, 2025
@jnels124 jnels124 self-assigned this Jan 16, 2025
@jnels124 jnels124 force-pushed the 10074-contractsresults-and-contractsresultslogs-returns-nullable-and-empty-fields-if-requested-too-early branch from 6a44cb4 to fea63a4 Compare January 16, 2025 18:04
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.30%. Comparing base (498782b) to head (0786939).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
hedera-mirror-rest/dbpool.js 64.70% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10153      +/-   ##
============================================
+ Coverage     92.19%   92.30%   +0.10%     
+ Complexity     7858     7821      -37     
============================================
  Files           956      948       -8     
  Lines         32860    32861       +1     
  Branches       4152     4153       +1     
============================================
+ Hits          30296    30331      +35     
+ Misses         1587     1554      -33     
+ Partials        977      976       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jnels124
Copy link
Contributor Author

Scenario URL VUS Pass% RPS Pass RPS Avg. Req Duration Skipped? Comment
blockNumber /blocks/74175011 1500 100.00 1213.81/s 1213.81/s 1232.07ms No
blocks /blocks?limit=100 1500 99.74 1083.93/s 1081.11/s 1359.23ms No
contracts /contracts?limit=100 1500 99.34 797.49/s 792.23/s 1869.15ms No
contractsId /contracts/1077627 1500 100.00 2546.53/s 2546.53/s 585.73ms No
contractsIdResults /contracts/1077627/results?limit=100 1500 100.00 713.22/s 713.22/s 2079.18ms No
contractsIdResultsLogs /contracts/1077627/results/logs?limit=100 1500 100.00 708.84/s 708.84/s 2088.21ms No
contractsIdResultsTimestamp /contracts/1077627/results/1682635826.366674003 1500 100.00 1891.08/s 1891.08/s 788.21ms No
contractsIdState /contracts/1077627/state?limit=100 1500 99.88 1871.21/s 1868.96/s 797.20ms No
contractsResults /contracts/results?limit=100 1500 100.00 240.23/s 240.23/s 6188.82ms No
contractsResultsId /contracts/results/0x8cc7f0036115d677ed3168b2812d8d78519788d0919e3975e067b8b172ca8a28 1500 100.00 1690.35/s 1690.35/s 878.95ms No
contractsResultsIdActions /contracts/results/0x8cc7f0036115d677ed3168b2812d8d78519788d0919e3975e067b8b172ca8a28/actions?limit=100 1500 99.90 3466.91/s 3463.44/s 429.47ms No
contractsResultsLogs /contracts/results/logs?limit=100 1500 99.80 691.28/s 689.90/s 2151.01ms No
rampUp /accounts 1500 99.98 218.99/s 218.95/s 3316.56ms No

@jnels124 jnels124 marked this pull request as ready for review January 16, 2025 19:33
@jnels124 jnels124 requested a review from a team as a code owner January 16, 2025 19:34
Signed-off-by: Jesse Nelson <[email protected]>
xin-hedera
xin-hedera previously approved these changes Jan 17, 2025
Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hedera-mirror-rest/config/application.yml Outdated Show resolved Hide resolved
hedera-mirror-rest/server.js Outdated Show resolved Hide resolved
hedera-mirror-rest/server.js Outdated Show resolved Hide resolved
Signed-off-by: Jesse Nelson <[email protected]>
Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working rest Area: REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contracts/results/ and contracts/results/logs returns nullable and empty fields if requested too early
3 participants