Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ContractCallNativePrecompileTest #10190

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

steven-sheehy
Copy link
Member

@steven-sheehy steven-sheehy commented Jan 20, 2025

Description:

  • Add a fallback to genesis system files loaded from hedera app library
  • Fix ContractCallNativePrecompileTest
  • Move KV classes to a keyvalue sub-package

Related issue(s):

Fixes #10080

Notes for reviewer:

3359 tests completed, 284 failed, 6 skipped

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@steven-sheehy steven-sheehy added enhancement Type: New feature web3 Area: Web3 API labels Jan 20, 2025
@steven-sheehy steven-sheehy added this to the 0.122.0 milestone Jan 20, 2025
@steven-sheehy steven-sheehy self-assigned this Jan 20, 2025
@steven-sheehy steven-sheehy requested a review from a team as a code owner January 20, 2025 04:24
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.31%. Comparing base (0a8166b) to head (6e7b1e0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #10190   +/-   ##
=========================================
  Coverage     92.30%   92.31%           
- Complexity     7821     7826    +5     
=========================================
  Files           947      948    +1     
  Lines         32847    32869   +22     
  Branches       4151     4151           
=========================================
+ Hits          30321    30344   +23     
  Misses         1550     1550           
+ Partials        976      975    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Steven Sheehy <[email protected]>
Signed-off-by: Steven Sheehy <[email protected]>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
10 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Contributor

@bilyana-gospodinova bilyana-gospodinova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature web3 Area: Web3 API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ContractCallNativePrecompileTest test suite
2 participants