Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests in ContractCallServiceTest suite #10194

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

nickeynikolovv
Copy link
Contributor

Description:
This PR fixes 3 tests in ContractCallServiceTest. Fixes PAYER_ACCOUNT_NOT_FOUND error and some assertion messages

Related issue(s):

Related to #10087

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@nickeynikolovv nickeynikolovv added enhancement Type: New feature web3 Area: Web3 API modularizedEVM labels Jan 21, 2025
@nickeynikolovv nickeynikolovv requested a review from a team January 21, 2025 12:28
@nickeynikolovv nickeynikolovv self-assigned this Jan 21, 2025
Signed-off-by: Nikolay Nikolov <[email protected]>
@nickeynikolovv nickeynikolovv force-pushed the 10087-Fix-ContractCallServiceTest branch from 2ab88e1 to 12b8e04 Compare January 21, 2025 12:31
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.21%. Comparing base (14f9a7c) to head (1269b3d).
Report is 17 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10194      +/-   ##
============================================
- Coverage     92.31%   92.21%   -0.10%     
- Complexity     7821     7924     +103     
============================================
  Files           947      965      +18     
  Lines         32847    33103     +256     
  Branches       4151     4173      +22     
============================================
+ Hits          30322    30526     +204     
- Misses         1550     1596      +46     
- Partials        975      981       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bilyana-gospodinova bilyana-gospodinova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 190b421 into main Jan 21, 2025
36 checks passed
@steven-sheehy steven-sheehy deleted the 10087-Fix-ContractCallServiceTest branch January 21, 2025 17:15
@steven-sheehy steven-sheehy added this to the 0.122.0 milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature modularizedEVM web3 Area: Web3 API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants