add ui.metrics.pathAllowlist to values.yaml #4445
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this field can be configured to override
ui_config.metrics.path_allowlist
in the server ui configuration whenui.metrics.enabled
is set totrue
Changes proposed in this PR
How I've tested this PR
I pulled this change into my local vendored copy of the helm chart and deployed it with these values.yaml settings modified:
In the diff (screenshot from argocd ui) i can see the config being applied in the correct location
After deployment I can see that queries in the UI to
/v1/internal/ui/metrics-proxy
succeed and metrics are displayed in the UIHow I expect reviewers to test this PR
Checklist