Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ui.metrics.pathAllowlist to values.yaml #4445

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

agrahamlincoln
Copy link

@agrahamlincoln agrahamlincoln commented Dec 17, 2024

this field can be configured to override ui_config.metrics.path_allowlist in the server ui configuration when ui.metrics.enabled is set to true

Changes proposed in this PR

  • add new option to values.yaml
  • add this option into server-config-configmap.yaml to modify the template

How I've tested this PR

I pulled this change into my local vendored copy of the helm chart and deployed it with these values.yaml settings modified:

ui:
  enabled: true
  metrics:
    enabled: true
    baseUrl: http://consul-prometheus.consul.svc.cluster.local:9090/consul
    provider: prometheus
    pathAllowlist:
      - /consul/api/v1/query_range
      - /consul/api/v1/query

In the diff (screenshot from argocd ui) i can see the config being applied in the correct location
Screenshot 2024-12-17 at 12 37 01 PM

After deployment I can see that queries in the UI to /v1/internal/ui/metrics-proxy succeed and metrics are displayed in the UI

How I expect reviewers to test this PR

Checklist

@agrahamlincoln agrahamlincoln requested review from a team as code owners December 17, 2024 19:15
Copy link

hashicorp-cla-app bot commented Dec 17, 2024

CLA assistant check
All committers have signed the CLA.

this field can be configured to override `ui_config.metrics.path_allowlist` in
the server ui configuration when `ui.metrics.enabled` is set to `true`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant